Rename ArrayEq/Hash Precision to EqMode#8214
Conversation
AdamGS
requested review from
a10y,
gatesn and
joseph-isaacs
and removed request for
a10y,
gatesn and
joseph-isaacs
Merging this PR will not alter performance
|
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
accuracy is the wrong word
|
exactness? |
|
how about splitting it into two functions on the same trait? the enum seems confusing |
|
should we just call this |
AdamGS
changed the title
EqMode
|
|
||
| impl ArrayHash for ALPData { | ||
| fn array_hash<H: Hasher>(&self, state: &mut H, _precision: Precision) { | ||
| fn array_hash<H: Hasher>(&self, state: &mut H, _accuracy: EqMode) { |
There was a problem hiding this comment.
should call these mode?
There was a problem hiding this comment.
there are like 10 million of them, I changed the trait so future impls will get filled in by IDEs
There was a problem hiding this comment.
It is a simple find and replace
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/rename-percision-to-accuracy
branch
from
c39a1c6 to
43f8e82
Compare
4 participants
Summary
This PR renames the
Precisionenum that we use to do array hashing and equality checks toAccuracy, as we already have aPrecisionenum we use for stats, that is also part of the binary format.API Changes
Just the renamed enum, which should be relatively minor.
Testing
N/A